-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the definitions of Active and Final status #389
Conversation
msfeldstein
commented
Aug 29, 2019
- Modify the Final status to be one in which there are live implementations being used. Previously, Final and Active were too similar, and often misused.
- Requires a Final SEP to have multiple implementations will give us much more confidence to mark something as final since we probably got most of the edge cases handled.
- Strongly suggests an Active SEP needs to have a reference implementation
- Modify the Final status to be one in which there are live implementations being used. Previously, Final and Active were too similar, and often misused. - Requires a Final SEP to have multiple implementations will give us much more confidence to mark something as final since we probably got most of the edge cases handled. - Strongly suggests an Active SEP needs to have a reference implementation
ecosystem/README.md
Outdated
updated to correct errata. | ||
ecosystem. Additional updates may be made without changing the SEP number. | ||
* **Final** - A finalized SEP that is being used in live products and will not be changed aside from | ||
minor errata. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This statement makes it sound like the primary reason for a proposal to be a candidate for being 'Final' is that it has been adopted in live products. I think we could have 'Active' proposals that have a few live implementations that aren't ready for being finalized.
I think we should reverse the sentence and make the focus that the primary attribute of a 'Final' proposal is that it will not change.
A finalized SEP will not be changed aside from minor errata. For a proposal to be a candidate to be made
Final
it must be being used in live products.
ecosystem/README.md
Outdated
* Minor changes may be made as more implementations are brought online highlighting any edge cases. | ||
|
||
### Active -> Final | ||
* Once there are live implementations being used in production, the SEP team can move the SEP to `Final` status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than live implementations being the trigger, can we make it a requirement? I think the trigger should be that a decision has been made that the proposal is complete, proven, and won't be extended, and one of the most important attributes to consider when making that decision is if it's being used in live products.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These revisions make a lot of sense to me, and I think being judicious marking something Final
is super important moving forward.