Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEP6 clarify error messaging #403

Merged
merged 1 commit into from
Sep 16, 2019
Merged

SEP6 clarify error messaging #403

merged 1 commit into from
Sep 16, 2019

Conversation

msfeldstein
Copy link
Contributor

@msfeldstein msfeldstein commented Sep 16, 2019

For /withdraw and /deposit, we need to indicate that the error message is a string to be displayed to users, and also have a language option for localization.

Fixes #402

For /withdraw and /deposit, we need to indicate that message is a string, and also have a language option for localization.
Copy link
Contributor

@morleyzhi morleyzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though I think we should also add documentation for a new error_metadata (or a different name that serves the same purpose.)

@msfeldstein
Copy link
Contributor Author

What do you expect error_metadata to be used for?

Copy link
Contributor

@tomquisel tomquisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm not so pumped about the complexity of the extra lang parameter, but I don't know how else to do it. I'd also bring up that the how response field for /deposit should be internationalized based on lang

@morleyzhi
Copy link
Contributor

@msfeldstein That's so the anchor can provide more structured data about the error, like a list of invalid inputs, for example.

@msfeldstein
Copy link
Contributor Author

We can do a follow up for that if we need, im not sure how it would work since we would need to either define a set of available values, or clients and anchors would need to work together to come to consensus among themselves about what fields are and mean.

@msfeldstein msfeldstein merged commit 4c0e778 into master Sep 16, 2019
@tomquisel tomquisel deleted the msfeldstein-patch-8-1 branch October 4, 2019 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SEP0006: Make it clear that error responses should be strings
3 participants