Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preparing for 1.4.0 release stuff #110

Merged
merged 2 commits into from
Mar 20, 2024
Merged

preparing for 1.4.0 release stuff #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db6b27a
fix
acharb Mar 19, 2024
5d56bfd
fix webpack process
acharb Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion @stellar/typescript-wallet-sdk-km/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@
"prepare": "husky install",
"test": "jest --watchAll",
"test:ci": "jest --ci",
"build": "webpack --config webpack.config.js"
"build:web": "webpack --config webpack.config.js",
Copy link
Contributor Author

@acharb acharb Mar 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

km should build for web and node like the regular wallet sdk is

"build:node": "webpack --env NODE=true --config webpack.config.js",
"build": "run-p build:web build:node"
}
}
8 changes: 8 additions & 0 deletions @stellar/typescript-wallet-sdk-km/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
const path = require("path");
const webpack = require("webpack");

module.exports = (env = { NODE: false }) => ({
mode: "development",
Expand All @@ -22,6 +23,8 @@ module.exports = (env = { NODE: false }) => ({
stream: require.resolve("stream-browserify"),
url: require.resolve("url"),
util: require.resolve("util"),
vm: require.resolve("vm-browserify"),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

webpack 5 is throwing annoying warning saying we need to polyfill this now, so added

"process/browser": require.resolve("process/browser"),
},
},
output: {
Expand All @@ -32,4 +35,9 @@ module.exports = (env = { NODE: false }) => ({
path: path.resolve(__dirname, "lib"),
},
target: env.NODE ? "node" : "web",
plugins: [
new webpack.ProvidePlugin({
process: "process/browser",
}),
],
});
Loading
Loading