preparing for 1.4.0 release stuff #110
Conversation
|
there was an extra yarn.lock in the |
| @@ -22,6 +22,7 @@ module.exports = (env = { NODE: false }) => ({ | |||
| stream: require.resolve("stream-browserify"), | |||
| url: require.resolve("url"), | |||
| util: require.resolve("util"), | |||
| vm: require.resolve("vm-browserify"), | |||
There was a problem hiding this comment.
webpack 5 is throwing annoying warning saying we need to polyfill this now, so added
| @@ -47,6 +47,8 @@ | |||
| "prepare": "husky install", | |||
| "test": "jest --watchAll", | |||
| "test:ci": "jest --ci", | |||
| "build": "webpack --config webpack.config.js" | |||
| "build:web": "webpack --config webpack.config.js", | |||
There was a problem hiding this comment.
km should build for web and node like the regular wallet sdk is
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is filesystem access?Accesses the file system, and could potentially read sensitive data. If a package must read the file system, clarify what it will read and ensure it reads only what it claims to. If appropriate, packages can leave file system access to consumers and operate on data passed to it instead. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
| @@ -32,4 +35,9 @@ module.exports = (env = { NODE: false }) => ({ | |||
| path: path.resolve(__dirname, "lib"), | |||
| }, | |||
| target: env.NODE ? "node" : "web", | |||
| plugins: [ | |||
There was a problem hiding this comment.
also needed to add this for React environment build
(not sure why wasn't needed before, maybe bc webpack version upgraded for this PR)
* fix broken test (#93) * add sep10 sign challenge txn helper (#95) * add sep10 helper method * name change * correct resp * create server module * add npm publish gha (#96) * WAL-1064 - add anchor platform integration tests (#99) * create workspace (#101) * create workspace * try * try * try * try * cleanup * update anchor platform docker run * fix * fix * upgrade babel/traverse * upgrade browserify-sign * add keypair package in a second workspace (#102) * add km package * fix tests * cleanup * add second CD (#109) * fix stellar-sdk imports (#112) * fix imports * fix * preparing for 1.4.0 release stuff (#110) * fix * fix webpack process * webpack fix (#113) * webpack fix * cleanup * add helper for parsing AnchorTransaction (#111) * add helper for parsing AnchorTransaction * use kind * add try-catch --------- Co-authored-by: Alec Charbonneau <aleccharb21@gmail.com>
some cleanup for the 1.4.0 release
tested building / using now and looks good with these changes