Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WAL-1064 - add anchor platform integration tests #99

Merged
merged 16 commits into from
Feb 21, 2024

Conversation

acharb
Copy link
Contributor

@acharb acharb commented Feb 20, 2024

@acharb acharb marked this pull request as draft February 20, 2024 22:45
@acharb acharb marked this pull request as ready for review February 21, 2024 17:49
@acharb acharb changed the title add anchor platform integration tests WAL-1064 - add anchor platform integration tests Feb 21, 2024
anchor({ homeDomain, language = this.language }: WalletAnchor): Anchor {
anchor({
homeDomain,
allowHttp = false,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allowing http for home domain anchors for testnet only

@acharb
Copy link
Contributor Author

acharb commented Feb 21, 2024

@Ifropc Anchor platform is great 🙌

I was thinking we might want to start moving some of the existing tests away from test anchor to anchor platform since testanchor had been giving some issues.

wdyt?

@acharb
Copy link
Contributor Author

acharb commented Feb 21, 2024

or maybe all tests? 🤔

@Ifropc
Copy link
Contributor

Ifropc commented Feb 21, 2024

Sounds good, ideally all tests could be done with docker, so we are not dependent on any issues with testanchor

@acharb
Copy link
Contributor Author

acharb commented Feb 21, 2024

Sounds good, ideally all tests could be done with docker, so we are not dependent on any issues with testanchor

cool I created a low priority ticket to move them here:
https://stellarorg.atlassian.net/browse/WAL-1320

@acharb acharb merged commit 888fd71 into release/1.4.0 Feb 21, 2024
5 checks passed
@acharb acharb deleted the acharb-anchorplatform branch February 21, 2024 20:33
acharb added a commit that referenced this pull request Mar 26, 2024
* fix broken test (#93)

* add sep10 sign challenge txn helper (#95)

* add sep10 helper method

* name change

* correct resp

* create server module

* add npm publish gha (#96)

* WAL-1064 - add anchor platform integration tests (#99)

* create workspace (#101)

* create workspace

* try

* try

* try

* try

* cleanup

* update anchor platform docker run

* fix

* fix

* upgrade babel/traverse

* upgrade browserify-sign

* add keypair package in a second workspace (#102)

* add km package

* fix tests

* cleanup

* add second CD (#109)

* fix stellar-sdk imports (#112)

* fix imports

* fix

* preparing for 1.4.0 release stuff (#110)

* fix

* fix webpack process

* webpack fix (#113)

* webpack fix

* cleanup

* add helper for parsing AnchorTransaction (#111)

* add helper for parsing AnchorTransaction

* use kind

* add try-catch

---------

Co-authored-by: Alec Charbonneau <aleccharb21@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants