Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust: Add read xdr to end fns #142

Merged
merged 12 commits into from
Sep 29, 2022
Merged

Rust: Add read xdr to end fns #142

merged 12 commits into from
Sep 29, 2022

Conversation

leighmcculloch
Copy link
Member

What

Add read xdr to end fns to the generated Rust code, and use them for base64 decoding.

Why

A lot of the time when reading from a stream into a value we want to read the entire stream into that one value, and for there to be extra data in the stream that is an error, because we don't expect there to be any extra data, and that data might be something we're discarding when we shouldn't be.

It's helpful to have functions that do this for us, so that the caller doesn't have to do this themselves.

The _to_end style functions are aligned with an existing pattern in the std::io::Read trait, where functions that end in _to_end read the stream all the way to the end. Although the function names do read a little odd. There might be a better name for this, but I haven't found it.

@leighmcculloch leighmcculloch enabled auto-merge (squash) September 29, 2022 06:41
@leighmcculloch leighmcculloch merged commit 9fccddf into master Sep 29, 2022
@leighmcculloch leighmcculloch deleted the rust-read-to-end branch September 29, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants