Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pulling versions with crossing-go #3

Open
danielc2013 opened this issue May 23, 2019 · 0 comments
Open

Allow pulling versions with crossing-go #3

danielc2013 opened this issue May 23, 2019 · 0 comments
Assignees
Labels

Comments

@danielc2013
Copy link
Contributor

danielc2013 commented May 23, 2019

Add an option like crossing-go get --version $VERSION_ID to allow for pulling versions of files in S3

Relevant documentation: https://docs.aws.amazon.com/sdk-for-go/api/service/s3/#GetObjectInput
Spot to add the version: https://github.com/stelligent/crossing-go/blob/master/cmd/get.go#L76

Note:
This will also require changing the Maximum number of arguments allowed for the "get" command. You'll have to provide a flag and the VersionId which means the max number of arguments should be 4. Then, you'll have to change how the s3 url is detected. Instead of assuming it's at position 0 of the args.

Finally, consider adding some validation to the VersionId to make sure the input is correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants