Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

major: Better Database API - Dorsal v0.1.7 #2

Closed
4 tasks done
hkauso opened this issue Jun 24, 2024 · 1 comment
Closed
4 tasks done

major: Better Database API - Dorsal v0.1.7 #2

hkauso opened this issue Jun 24, 2024 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@hkauso
Copy link
Member

hkauso commented Jun 24, 2024

Crangon needs to have major portions rewritten in order to match the behavior of Dorsal v0.1.4.

  • crangon::db::Database functions need to begin returning Result<T, PasteError> instead of DefaultReturn<T> (5430634)
    • These Results need to be translated back into DefaultReturn before returned through API functions
  • Every API function that references the main Database needs to be partially or fully rewritten to be better optimized
    • This means: Less cloning, prefer match over big if conditionals, etc
  • The API function rewrites may also apply to page handlers
@hkauso hkauso added bug Something isn't working enhancement New feature or request labels Jun 24, 2024
@hkauso hkauso added this to the Better Database API milestone Jun 24, 2024
@hkauso hkauso changed the title Better Database API - Dorsal v0.1.4 major: Better Database API - Dorsal v0.1.4 Jun 24, 2024
hkauso added a commit that referenced this issue Jun 24, 2024
fix: full log_db (#2)
fix: staff pages (#2)
@hkauso hkauso pinned this issue Jun 24, 2024
hkauso added a commit that referenced this issue Jun 24, 2024
@hkauso
Copy link
Member Author

hkauso commented Jun 24, 2024

Remaining API/Page handler refactoring:

hkauso added a commit that referenced this issue Jun 27, 2024
hkauso added a commit that referenced this issue Jun 27, 2024
@hkauso hkauso changed the title major: Better Database API - Dorsal v0.1.4 major: Better Database API - Dorsal v0.1.7 Jun 29, 2024
hkauso added a commit that referenced this issue Jun 30, 2024
fix: lifetime errors
fix: cookie read
@hkauso hkauso closed this as completed Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

1 participant