New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sheets (Round 1) #326

Closed
wants to merge 45 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@oliver----
Copy link
Member

oliver---- commented Aug 10, 2017

Rewrite of the former prototype with the aim to provide a restrictive version for Datatables very soon.

oliver---- added some commits Aug 9, 2017

@oliver----

This comment has been minimized.

Copy link
Member

oliver---- commented Aug 10, 2017

First version: having a very flexible approach using a view-port, which is by design embeddable and can be used for arbitrary large tables. Implemented scrolling and selections.

preview-stencila-sheets-selection

preview-stencila-sheets-scrolling

@oliver----

This comment has been minimized.

Copy link
Member

oliver---- commented Aug 11, 2017

Row and column selections:

preview-stencila-sheets-row-and-column-selections

@oliver----

This comment has been minimized.

Copy link
Member

oliver---- commented Aug 15, 2017

stencila-sheets-basic-editing

nokome and others added some commits Aug 16, 2017

Merge pull request #329 from stencila/sheets-schema
Add a SpreadsheetSchema.md
@oliver----

This comment has been minimized.

Copy link
Member

oliver---- commented Aug 16, 2017

Keyboard nav:
stencila-sheets-keyboard-nav

oliver---- added some commits Aug 16, 2017

@oliver----

This comment has been minimized.

Copy link
Member

oliver---- commented Aug 16, 2017

Need some sleep.

@nokome

This comment has been minimized.

Copy link
Member

nokome commented Aug 16, 2017

I'm unable to npm install this branch, even after doing rm -rf node_modules. Am I doing something wrong?

npm install
npm WARN prepublish-on-install As of npm@5, `prepublish` scripts will run only for `npm publish`.
npm WARN prepublish-on-install (In npm@4 and previous versions, it also runs for `npm install`.)
npm WARN prepublish-on-install See the deprecation note in `npm help scripts` for more information.

> stencila@0.27.9 prepublish /home/nokome/stencila/source/stencila
> node make

Remove: build
Remove: tmp
Copy: ./node_modules/font-awesome -> ./build/font-awesome
Copy: ./vendor/brace.* -> ./build/lib/
Copy: ./vendor/vega* -> ./build/lib/
Copy: ./vendor/unified* -> ./build/lib/
Copy: ./node_modules/d3/build/d3.min.js -> ./build/lib/
Copy: ./node_modules/katex/dist/ -> ./build/katex
Copy: ./node_modules/substance/dist/substance.js* -> ./build/lib/
Copy: ./node_modules/stencila-mini/dist/stencila-mini.js* -> ./build/lib/
PostCSS:/home/nokome/stencila/source/stencila/src/pagestyle/stencila.css->/home/nokome/stencila/source/stencila/build/stencila.css
..finished in 237 ms.
Compiling schema 'SpreadsheetSchema'...

Error during execution of Command  custom
Error: Not supported yet
Stacktrace:
Error: Not supported yet
    at _processSequence (/home/nokome/stencila/source/stencila/node_modules/substance/dist/substance/xml/compileRNG.js:182:15)
    at _compile (/home/nokome/stencila/source/stencila/node_modules/substance/dist/substance/xml/compileRNG.js:97:15)
    at compileRNG (/home/nokome/stencila/source/stencila/node_modules/substance/dist/substance/xml/compileRNG.js:26:3)
    at CustomAction.execute [as _execute] (/home/nokome/stencila/source/stencila/make.js:299:25)
    at CustomAction.execute (/home/nokome/stencila/source/stencila/node_modules/substance-bundler/src/commands/CustomCommand.js:152:33)
    at CustomCommand._executeWithoutGlob (/home/nokome/stencila/source/stencila/node_modules/substance-bundler/src/commands/CustomCommand.js:51:19)
    at CustomCommand.execute (/home/nokome/stencila/source/stencila/node_modules/substance-bundler/src/commands/CustomCommand.js:40:19)
    at Bundler._next (/home/nokome/stencila/source/stencila/node_modules/substance-bundler/src/Bundler.js:289:30)
    at Bundler._step (/home/nokome/stencila/source/stencila/node_modules/substance-bundler/src/Bundler.js:330:12)
    at _combinedTickCallback (internal/process/next_tick.js:73:7)
    at process._tickCallback (internal/process/next_tick.js:104:9)

@oliver---- oliver---- force-pushed the sheets branch from fb6e1f9 to 76315c0 Aug 17, 2017

@michael

This comment has been minimized.

Copy link
Member

michael commented Aug 17, 2017

@nokome you need to do an npm link setup using the improvements branch of Substance.

  1. in the substance repo do a node make
  2. then do npm link
  3. in the stencila repo do npm link substance
@nokome

This comment has been minimized.

Copy link
Member

nokome commented Aug 18, 2017

Thanks @michael it worked!

@oliver---- oliver---- force-pushed the sheets branch 2 times, most recently from fc58d69 to 4665696 Aug 20, 2017

@oliver---- oliver---- force-pushed the sheets branch from 4a6f3a4 to 81b241e Sep 7, 2017

oliver---- added some commits Sep 7, 2017

@oliver---- oliver---- force-pushed the sheets branch from 0da46f3 to 4b297ce Sep 8, 2017

oliver---- added some commits Sep 8, 2017

@oliver---- oliver---- force-pushed the sheets branch from f6a447d to dfde318 Sep 12, 2017

@oliver---- oliver---- force-pushed the sheets branch from dfde318 to e966d69 Sep 13, 2017

@oliver---- oliver---- force-pushed the sheets branch from 194e380 to 37160a6 Sep 13, 2017

@oliver----

This comment has been minimized.

Copy link
Member

oliver---- commented Sep 13, 2017

@nokome ^^ :)

@oliver----

This comment has been minimized.

Copy link
Member

oliver---- commented Sep 13, 2017

stencila-sheets-column-types

@oliver---- oliver---- force-pushed the sheets branch from 95d33d2 to 05ce803 Sep 14, 2017

@oliver---- oliver---- force-pushed the sheets branch from 05ce803 to cbaf25e Sep 14, 2017

@oliver---- oliver---- changed the title WIP: Spreadsheets Sheets (Round 1) Sep 15, 2017

@oliver----

This comment has been minimized.

Copy link
Member

oliver---- commented Sep 15, 2017

First version of a linter:

stencila-sheet-linter

@oliver----

This comment has been minimized.

Copy link
Member

oliver---- commented Sep 15, 2017

We call this now the first round. Gonna merge this PR into develop.

@oliver----

This comment has been minimized.

Copy link
Member

oliver---- commented Sep 15, 2017

Closing this PR, because it was started on master.

@oliver---- oliver---- closed this Sep 15, 2017

@oliver---- oliver---- referenced this pull request Sep 15, 2017

Merged

Sheets (Round 1) #349

@oliver---- oliver---- deleted the sheets branch Sep 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment