Sheets (Round 1) #326
Closed
Sheets (Round 1) #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First version: having a very flexible approach using a view-port, which is by design embeddable and can be used for arbitrary large tables. Implemented scrolling and selections.
|
|
Row and column selections:
|
|
|
|
Keyboard nav: |
|
Need some sleep. |
|
I'm unable to npm install
npm WARN prepublish-on-install As of npm@5, `prepublish` scripts will run only for `npm publish`.
npm WARN prepublish-on-install (In npm@4 and previous versions, it also runs for `npm install`.)
npm WARN prepublish-on-install See the deprecation note in `npm help scripts` for more information.
> stencila@0.27.9 prepublish /home/nokome/stencila/source/stencila
> node make
Remove: build
Remove: tmp
Copy: ./node_modules/font-awesome -> ./build/font-awesome
Copy: ./vendor/brace.* -> ./build/lib/
Copy: ./vendor/vega* -> ./build/lib/
Copy: ./vendor/unified* -> ./build/lib/
Copy: ./node_modules/d3/build/d3.min.js -> ./build/lib/
Copy: ./node_modules/katex/dist/ -> ./build/katex
Copy: ./node_modules/substance/dist/substance.js* -> ./build/lib/
Copy: ./node_modules/stencila-mini/dist/stencila-mini.js* -> ./build/lib/
PostCSS:/home/nokome/stencila/source/stencila/src/pagestyle/stencila.css->/home/nokome/stencila/source/stencila/build/stencila.css
..finished in 237 ms.
Compiling schema 'SpreadsheetSchema'...
Error during execution of Command custom
Error: Not supported yet
Stacktrace:
Error: Not supported yet
at _processSequence (/home/nokome/stencila/source/stencila/node_modules/substance/dist/substance/xml/compileRNG.js:182:15)
at _compile (/home/nokome/stencila/source/stencila/node_modules/substance/dist/substance/xml/compileRNG.js:97:15)
at compileRNG (/home/nokome/stencila/source/stencila/node_modules/substance/dist/substance/xml/compileRNG.js:26:3)
at CustomAction.execute [as _execute] (/home/nokome/stencila/source/stencila/make.js:299:25)
at CustomAction.execute (/home/nokome/stencila/source/stencila/node_modules/substance-bundler/src/commands/CustomCommand.js:152:33)
at CustomCommand._executeWithoutGlob (/home/nokome/stencila/source/stencila/node_modules/substance-bundler/src/commands/CustomCommand.js:51:19)
at CustomCommand.execute (/home/nokome/stencila/source/stencila/node_modules/substance-bundler/src/commands/CustomCommand.js:40:19)
at Bundler._next (/home/nokome/stencila/source/stencila/node_modules/substance-bundler/src/Bundler.js:289:30)
at Bundler._step (/home/nokome/stencila/source/stencila/node_modules/substance-bundler/src/Bundler.js:330:12)
at _combinedTickCallback (internal/process/next_tick.js:73:7)
at process._tickCallback (internal/process/next_tick.js:104:9)
|
|
@nokome you need to do an npm link setup using the
|
|
Thanks @michael it worked! |
obuchtala
force-pushed
the
sheets
branch
2 times, most recently
from
fc58d69
to
4665696
Compare
|
@nokome ^^ :) |
|
|
|
First version of a linter:
|
|
We call this now the first round. Gonna merge this PR into develop. |
|
Closing this PR, because it was started on master. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite of the former prototype with the aim to provide a restrictive version for Datatables very soon.