Warn about the high performance cost of JINC2 and xBR filtering #2889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These options (especially xBR) have a very high cost. In my experience, xBR has a greater impact on the framerate than enabling 4× SSAA or PGXP in CPU mode (whose quality increase is much more obvious). These options are also essentially unusable on mobile, regardless of how powerful your device is. As a result, this adds warnings both in the option names and the description. Bilinear filtering is not affected by this performance cost, as GPUs can perform this in hardware without having to emulate filtering through a shader.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These options (especially xBR) have a very high cost. In my experience, xBR has a greater impact on the framerate than enabling 4× SSAA or PGXP in CPU mode (whose quality increase is much more obvious).
These options are also essentially unusable on mobile, regardless of how powerful your device is. As a result, this adds warnings both in the option names and the description.
Bilinear filtering is not affected by this performance cost, as GPUs can perform this in hardware without having to emulate filtering through a shader.
Benchmark
System information
System
OS: Fedora 36
CPU: Intel Core i7-6700K (4.4 GHz)
GPU: GeForce GTX 1080 (NVIDIA 515.65.01)
DuckStation settings
Renderer: Vulkan
Resolution scale: 6× (+ 16:9 widescreen)
Crop: All Borders
PGXP: Enabled (with Culling Correction, Texture Correction, Preserve Projection Precision, Vertex Cache)
Note: "No Edge Blending" modes perform identically to the standard modes.
Nearest-Neighbor
Bilinear
JINC2
xBR