Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad description in FFI schema for Group 12 variations 0 and 1 #306

Closed
jadamcrain opened this issue Jul 13, 2023 · 0 comments · Fixed by #308
Closed

Bad description in FFI schema for Group 12 variations 0 and 1 #306

jadamcrain opened this issue Jul 13, 2023 · 0 comments · Fixed by #308
Assignees
@jadamcrain
Labels
documentation Improvements or additions to documentation

Comments

@jadamcrain
Copy link
Member

dnp3/ffi/dnp3-schema/src/variation.rs

Line 41 in c3987dc

.push(

Also, I don't think we should have a variation 0 at all for group 12 or group 41.

I don't think this is a bug in the library per say but it definitely is produced incorrect documentation for users in all of the bindings languages.
@jadamcrain jadamcrain added the documentation Improvements or additions to documentation label Jul 13, 2023
@jadamcrain jadamcrain self-assigned this Jul 13, 2023
@jadamcrain jadamcrain mentioned this issue Jul 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jadamcrain jadamcrain

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix docs for g12v1 and removes g12v0 and g41v0 stepfunc/dnp3
1 participant
@jadamcrain