Load index information from Atlas schema files #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbezhanov
commented
Jun 18, 2024
mbezhanov
force-pushed
the
index-information-atlas
branch
3 times, most recently
from
8430413
to
3beefad
Compare
mbezhanov
force-pushed
the
index-information-atlas
branch
from
3beefad
to
a7457ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing what I started in #237, this PR adds proper support for loading index information from Atlas schema files.
I wanted to do the Atlas and Prisma driver modifications together, but the Atlas implementation took a bit longer than I anticipated.
I had to update the original
schema.hclfiles, as they had some small issues preventing theatlasCLI from executing them against real MySQL, PostgreSQL, and SQLite databases (now it works).All questions and comments are welcome.