Make sure #normalized_path does not depend on modifying @path.

stephencelis · Apr 11, 2011 · 79c5640 · 79c5640
1 parent 93a4588
commit 79c5640
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/lib/addressable/uri.rb b/lib/addressable/uri.rb
@@ -1266,14 +1266,14 @@ def path
     # @return [String] The path component, normalized.
     def normalized_path
       @normalized_path ||= (begin
-        if self.scheme == nil && self.path != nil && !self.path.empty? &&
-            self.path =~ NORMPATH
+        path = self.path
+        if self.scheme == nil && path != nil && !self.path.empty? && path =~ NORMPATH
           # Relative paths with colons in the first segment are ambiguous.
-          self.path.sub(":", "%2F")
+          path.sub!(":", "%2F")
         end
         # String#split(delimeter, -1) uses the more strict splitting behavior
         # found by default in Python.
-        result = (self.path.strip.split(SLASH, -1).map do |segment|
+        result = (path.strip.split(SLASH, -1).map do |segment|
           Addressable::URI.normalize_component(
             segment,
             Addressable::URI::CharacterClasses::PCHAR