Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

requestPermissionsAsync() does not reject the promise in case of failure #3

Closed
erichimm opened this issue Feb 28, 2020 · 0 comments · Fixed by #4
Closed

requestPermissionsAsync() does not reject the promise in case of failure #3

erichimm opened this issue Feb 28, 2020 · 0 comments · Fixed by #4

Comments

@erichimm
Copy link
Contributor

In useLocation.js, requesting user permissions is incomplete. As per the docs here, this function always resolves with a PermissionResponse object, even if permission is not granted.

Our code needs to check the response object, and throw an error manually in order to enter the catch block as expected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix location permission request not throwing an error erichimm/rn-casts
1 participant
@erichimm