Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add assertLoaded #578

Merged
merged 1 commit into from
Mar 22, 2023
Merged

feat: add assertLoaded #578

merged 1 commit into from
Mar 22, 2023

Conversation

zgavin
Copy link
Collaborator

@zgavin zgavin commented Mar 22, 2023

  • Added assertLoaded that fails if the entity isn't loaded for its hint
  • Added ensureWithLoaded that returns a WithLoaded after calling assertLoaded

Breaking Changes

  • Renamed ensureLoadedThen to maybePopulateThen as the naming was non-obvious
  • Repurposed unused ensureLoaded to assertLoaded then return its entity

…d (which was unused), renamed ensureLoadedThen to maybePopulateThen
@zgavin zgavin merged commit b3eb908 into main Mar 22, 2023
stephenh pushed a commit that referenced this pull request Mar 22, 2023
# [1.64.0](v1.63.4...v1.64.0) (2023-03-22)

### Features

* added assertLoaded and ensureWithLoaded, repurposed ensureLoaded, renamed ensureLoadedThen to maybePopulateThen ([#578](#578)) ([b3eb908](b3eb908))
@stephenh
Copy link
Collaborator

🎉 This PR is included in version 1.64.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@stephenh stephenh deleted the assertLoaded branch September 29, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants