Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix DELETEs bumping oplocks for UPDATEs. #593

Merged
merged 1 commit into from
Mar 30, 2023
Merged

fix: Fix DELETEs bumping oplocks for UPDATEs. #593

merged 1 commit into from
Mar 30, 2023

Conversation

stephenh
Copy link
Collaborator

Fixes #591.

stephenh
stephenh commented Mar 29, 2023
View reviewed changes
packages/orm/src/drivers/PostgresDriver.ts
for await (const todo of Object.values(todos)) {
if (todo) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this if (todo) which made the diff uglier...

@stephenh stephenh requested a review from chr1sjf0x March 29, 2023 20:48
@stephenh stephenh merged commit 5817469 into main Mar 30, 2023
@stephenh stephenh deleted the fix-oplock-failures branch March 30, 2023 03:42
stephenh pushed a commit that referenced this pull request Mar 30, 2023
@semantic-release-bot
chore(release): 1.69.1 [skip ci]
0abf24f 
## [1.69.1](v1.69.0...v1.69.1) (2023-03-30)

### Bug Fixes

* Fix DELETEs bumping oplocks for UPDATEs. ([#593](#593)) ([5817469](5817469)), closes [#591](#591)
@stephenh
Copy link
Collaborator Author

🎉 This PR is included in version 1.69.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chr1sjf0x chr1sjf0x Awaiting requested review from chr1sjf0x

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Race condition with SET NULL constraints
1 participant
@stephenh