Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

./gradlew shadowJar produces wrong jar name #35

Closed
ediphy-azorab opened this issue Jun 13, 2019 · 1 comment
Closed

./gradlew shadowJar produces wrong jar name #35

ediphy-azorab opened this issue Jun 13, 2019 · 1 comment

Comments

@ediphy-azorab
Copy link
Contributor

It's possibly an artifact of my environment, but the output of the shadowJar task is called mirror.jar on my system, not mirror-all.jar.

It's simple enough to fix up the build scripts, but I don't want to do it if it's only my box it's happening on.

@stephenh
Copy link
Owner

stephenh commented Aug 4, 2019

Huh, you're right. This probably changed when I bumped a gradle version/something and didn't realize it.

I started changing all of the mirror-alls to just mirror, like you did in in #36, but also upgraded the gradle shadow plugin, and turns out that fixed it.

So, probably was a gradle upgrade not agreeing with an old version of the shadow plugin, but looks to be fixed now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants