Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript as peerDependency #1059

Closed
dglazkoff opened this issue Jun 11, 2024 · 3 comments
Closed

Typescript as peerDependency #1059

dglazkoff opened this issue Jun 11, 2024 · 3 comments

Comments

@dglazkoff
Copy link

Do you think maybe a typescript should be added as a peerDependency in the project?

@stephenh
Copy link
Owner

Hi @dglazkoff ; my initial assumption is no, because I've not really seen that done before (or at all?) but I guess maybe you're thinking that the peerDep would specify some minimal version of tsc that the code requires?

If so, honestly I'm not even sure what that is at the moment, i.e. I don't think we use any super-new-ish features of tsc, mostly I'm assuming though because we've not had any bug reports of people still on tsc 4.x asking about it.

@dglazkoff
Copy link
Author

Yes, I meant some minimum required typescript version. It may be useful to know this information)

@stephenh
Copy link
Owner

I think this is a fair ask (to know the minimum tsc version), but I think when/if we discover it, we would probably just include it in the readme, and not as a true peerDependency.

If you'd like to help bisect what our minimum version of tsc actually is (or if you're doing it anyway :-D ), that'd be great, otherwise I'll make sure to document it, the next time someone files an issue about what tsc feature we're using, that isn't supported by their version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants