Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed addGrpcMetadata option #761

Merged
merged 1 commit into from
Mar 13, 2024
Merged

fix: fixed addGrpcMetadata option #761

merged 1 commit into from
Mar 13, 2024

Conversation

vojty
Copy link
Contributor

@vojty vojty commented Jan 19, 2023 •
edited
Loading

This PR should fix this issue #188

I've removed addNestjsRestParameter parameter completely from src/generate-services.ts since NestJS seems to be handled in generate-nestjs file.

  • tests

@vojty vojty changed the title fix addGrpcMetadata for generic RPC client fix: fixed addGrpcMetadata option Jan 20, 2023
@vojty
Copy link
Contributor Author

vojty commented Mar 8, 2024

Hey, @stephenh would you be so kind and have some time to look at this, please?

stephenh
stephenh reviewed Mar 10, 2024
View reviewed changes
Copy link
Owner

@stephenh stephenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vojty ! Thanks for the PR, just a few questions, thanks!

integration/generic-metadata/hero.ts Outdated Show resolved Hide resolved
integration/generic-metadata/hero.ts Outdated Show resolved Hide resolved
@vojty
Copy link
Contributor Author

vojty commented Mar 12, 2024

I've added 2 separate tests. The expected output:

  1. metadataType=Foo - this should fix the current behavior and add optional metadata?: Foo to *Impl methods as well (the metadata parameter is currently present only in the type definition https://github.com/stephenh/ts-proto/blob/main/integration/generic-metadata/hero.ts#L289-L293)
  2. metadataType=Foo,addGrpcMetadata=true - the same as above
  3. addGrpcMetadata=true - adds optional metadata?: Metadata

@stephenh
Copy link
Owner

Looks great, thank you!

@stephenh stephenh merged commit cb2b573 into stephenh:main Mar 13, 2024
7 checks passed
stephenh pushed a commit that referenced this pull request Mar 13, 2024
@semantic-release-bot
chore(release): 1.169.1 [skip ci]
088d5a6 
## [1.169.1](v1.169.0...v1.169.1) (2024-03-13)

### Bug Fixes

* fixed addGrpcMetadata option ([#761](#761)) ([cb2b573](cb2b573))
@stephenh
Copy link
Owner

🎉 This PR is included in version 1.169.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Graysonbarton Graysonbarton mentioned this pull request May 21, 2024
Open
@VaniHaripriya VaniHaripriya mentioned this pull request Jun 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenh stephenh stephenh left review comments

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vojty @stephenh