Handle sorting when date or filesize is None (happens for folders in S3)

stephenmcd · Nov 13, 2015 · bb2440f · bb2440f
1 parent aa2b9fb
commit bb2440f
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/filebrowser_safe/views.py b/filebrowser_safe/views.py
@@ -156,7 +156,10 @@ def browse(request):
     # SORTING
     query['o'] = request.GET.get('o', DEFAULT_SORTING_BY)
     query['ot'] = request.GET.get('ot', DEFAULT_SORTING_ORDER)
-    files = sorted(files, key=lambda f: getattr(f, request.GET.get('o', DEFAULT_SORTING_BY)))
+    defaultValue = ''
+    if query['o'] in ['date', 'filesize']:
+        defaultValue = 0.0
+    files = sorted(files, key=lambda f: getattr(f, query['o']) or defaultValue)
     if not request.GET.get('ot') and DEFAULT_SORTING_ORDER == "desc" or request.GET.get('ot') == "desc":
         files.reverse()