Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming conventions #44

Closed
BenjaminPeter opened this issue May 18, 2015 · 3 comments
Closed

Naming conventions #44

BenjaminPeter opened this issue May 18, 2015 · 3 comments

Comments

@BenjaminPeter
Copy link

It would be nice to keep function names consistent.

Currently, there are functions that are dot separated (new.dsc), camelCase (addMethod) and underscore delimited (run_dsc). It would be nice to make the names consistent in one way or the other.
@stephens999
Copy link
Owner

I agree. After discussions with @ramanshah I think we should employ snake_case throughout. Perhaps we can keep the old functions around initially in a deprecated.R file, with a call to the new functions so that existing dscs will continue to run. But I think better to make this change sooner rather than later.

@ramanshah ramanshah mentioned this issue Jul 16, 2015
Open
5 tasks
@ramanshah ramanshah mentioned this issue Jul 30, 2015
Merged
@ramanshah
Copy link
Contributor

Resolved by #52.

@ramanshah
Copy link
Contributor

@stephens999 Sorry, I forgot to put the magic issue-closing stuff in the relevant git commit - please close. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stephens999 @BenjaminPeter @ramanshah