-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration with batchJobs #46
Comments
I've thought about this strategy. Here are my reasons for hesitation:
If you feel these aren't important, we can definitely do it this way. Your suggestion is probably the simplest implementation. |
I think 1 is presumably going to depend on the cluster environment, but it isn't a problem I have come across in practice with the clusters we are using. For 2 this scenario is indeed not out of the question, but easily dealt with: first run your dsc for all the fast methods. Then add the slow method and run that. For 3, I agree, but actually suspect that in most use cases it will be I think the issue is urgent enough, and this approach simple enough, that we would be best off implementing it first, and seeing what our next bottleneck turns out to be. |
Sounds good. |
Probably addresses #23 as well. |
We've had various discussions about how to provide better support for long-running jobs.
To me it seems that by making use of batchJobs, and particularly its waitForJobs function,
we should be able to get something that works with relatively little code.
Currently we have, in run_dsc, the code:
runScenarios(dsc,scenariosubset,seedsubset)
runMethods(dsc,scenariosubset,methodsubset,seedsubset)
runOutputParsers(dsc)
runScores(dsc,scenariosubset,methodsubset)
The simplest approach that I can see would involve submitting jobs to do each
of these functions, and using waitForJobs to wait between each job set.
runScenarios (by submitting to batchJobs)
waitForJobs()
runMethods (again through batchJobs, a second registry of jobs this)
waitForJobs()
runOutputparsers (again through batchJobs, a third registry)
waitForJobs()
runScores (batchJobs, a fourth registry)
waitForJobs()
@ramanshah is there a reason you can see that this would not work?
The text was updated successfully, but these errors were encountered: