Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New interface for summary statistics version #53

Closed
gaow opened this issue Oct 8, 2018 · 3 comments
Closed

New interface for summary statistics version #53

gaow opened this issue Oct 8, 2018 · 3 comments

Comments

@gaow
Copy link
Member

gaow commented Oct 8, 2018

@zouyuxin although we have discussed it in person, from my experience it is always best to open new issues for new features added to keep everybody in the loop even if we do not need to discuss it with others. We then close the issue only when the feature is documented and added to unit tests. Tickets helps us keeping track of development.

Yuxin and I have currently agreed to support 3 main susie function calls:

  1. susie, with input X, Y etc (already implemented).
  2. susie_z, with input Z and R where R is correlation. (we might optionally take var(Y) and sample size -- still working on it)
  3. susie_ss, with input betahat, sebetahat, varY, N and R where N is sample size and R can be correlation, covariance or X^TX.

The old susie_ss interface which takes X^TX, X^Y, etc, will be made an internal function.

Yuxin is working on the implementation now. We can discuss some more when she has the first draft of interface implemented and documented.

@pcarbo
Copy link
Member

pcarbo commented Oct 8, 2018

@gaow @zouyuxin Thanks for the summary! Is susie_z also working with summary statistics then? Maybe we should call the functions susie_ss_z and susie_ss_beta, or something like that?

@gaow
Copy link
Member Author

gaow commented Oct 8, 2018

Sure. Our initial thought was susie_z and susie_bs but the latter is apparently not good. @stephens999 do you have other suggestions or we use what @pcarbo proposed?

@stephens999
Copy link
Contributor

stephens999 commented Oct 8, 2018 via email

@gaow gaow closed this as completed Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants