-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coverage in susie_get_CS #69
Comments
@stephens999 what do you mean by this? Currently we simply copy around the input |
yes, that was my suggestion.
Do you think the requested coverage is important to keep?
…On Tue, Oct 30, 2018 at 7:26 PM gaow ***@***.***> wrote:
@stephens999 <https://github.com/stephens999> what do you mean by this?
Currently we simply copy around the input coverage. Are you suggesting we
compute the sum of PIP in each CS and report a L vector of overages? Still
it would be good to keep track of the requested coverage I guess. So maybe
we can use a different variable name for the new information?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#69 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABt4xVvAX4uaSD4TWhKY1DXT6Ym5poMVks5uqO4rgaJpZM4YDHgL>
.
|
Well, it might not harm to keep it. A possible scenario is that sometimes we request a high coverage that can only be satisfied at the cost of purity -- that is we have a large CS with low purity. If the purity is too low it will get filtered out, leaving empty CS output (in other words SuSiE finds nothing). It would be less confusing to report requested coverage along with an empty results, compared to otherwise. |
maybe we should return the claimed coverage (which may be > threshold) rather than the requested coverage?
The text was updated successfully, but these errors were encountered: