Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverage in susie_get_CS #69

Closed
stephens999 opened this issue Oct 31, 2018 · 3 comments
Closed

coverage in susie_get_CS #69

stephens999 opened this issue Oct 31, 2018 · 3 comments

Comments

@stephens999
Copy link
Contributor

maybe we should return the claimed coverage (which may be > threshold) rather than the requested coverage?

@gaow
Copy link
Member

gaow commented Oct 31, 2018

@stephens999 what do you mean by this? Currently we simply copy around the input coverage. Are you suggesting we compute the sum of PIP in each CS and report a L vector of overages? Still it would be good to keep track of the requested coverage I guess. So maybe we can use a different variable name for the new information?

@stephens999
Copy link
Contributor Author

stephens999 commented Oct 31, 2018 via email

@gaow
Copy link
Member

gaow commented Oct 31, 2018

Well, it might not harm to keep it. A possible scenario is that sometimes we request a high coverage that can only be satisfied at the cost of purity -- that is we have a large CS with low purity. If the purity is too low it will get filtered out, leaving empty CS output (in other words SuSiE finds nothing). It would be less confusing to report requested coverage along with an empty results, compared to otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants