Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label implementation #8

Closed
wants to merge 12 commits into from

Conversation

calekennedy
Copy link

#3
Implementation of features addressing this issue:

Client.listApplicantsLabels(applicant_id);
// already implemented
// added documentation to readme
// added tests

Client.updateApplicantsLabels(applicant_id, label_title, is_completed);
// added implementation
// added documentation to readme
// added tests

Client.listStagesLabels(stage_id);
// added implementation
// added documentation to readme
// needs test coverage

That covers all of the label management functionality listed on the v2 api documentation

https://www.onboardiq.com/docs/apiv2/

@calekennedy
Copy link
Author

Test runner seemed to fail in the CI process. Let me know if I can help solve the issue. Tests are passing locally.

@stephnr
Copy link
Owner

stephnr commented Mar 24, 2016

Thank you for the PR @calekennedy . I will review this shortly and run tests before including your edits

@calekennedy
Copy link
Author

Is there anything I can do to help with this PR?

@calekennedy
Copy link
Author

I think the problem with this PR is the OIQ api versioning. Is there any chance we can pull this in?

@stephnr
Copy link
Owner

stephnr commented Oct 18, 2016

I can review this. Perhaps we can change the way the tool itself perform tests. I have a new tool in use; wallaby. Let me get this working with mocha/chai/nock to organize the tests better

@stephnr
Copy link
Owner

stephnr commented Oct 18, 2016

@calekennedy make sure to grab the latest code with the improved testing suite and retest your code

@xingwang
Copy link

Hi @Stephn-R I've merged in your latest master and updated the specs using Cale's previous work.

@stephnr stephnr closed this Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants