Replicate parallel executions in forallParallelCommands
#43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevana
requested changes
Mar 22, 2024
|
@stevana I addressed all your comments except the |
jasagredo
force-pushed
the
js/replicate-in-forall
branch
from
dfa7313
to
384bfe5
Compare
|
I think some of the tests that I marked as non-failing are again failing as they were before. |
|
Indeed, I changed |
stevana
reviewed
Mar 25, 2024
This commit reverts 4c186f4. It also implements the change decribed in stevana#42, by which the repetition of parallel executions happens at the `forallParallelCommands` level and not in `runParallelCommands`.
jasagredo
force-pushed
the
js/replicate-in-forall
branch
2 times, most recently
from
daccfb5
to
7553d3e
Compare
jasagredo
commented
Mar 31, 2024
stevana
approved these changes
Apr 2, 2024
This was referenced Apr 2, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of #42. In general it can be seen as a revert of #12 and #11. This also makes #40 and #41 not necessary.
I would recommend isolating only a2f27d1 to view the relevant changes, the other commit just modifies the tests.
It is however important to note that in the tests I had a bunch of troubles with
Cleanupbecause it tries to test the internals of QSM, by assuming multiple repetitions in place. I'm open to discussion on how to best do this. For now as that one was using 2 repetitions I'm running the parallel machine two times.