Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downtime each nexus configuration change #579

Closed
holmesb opened this issue Dec 23, 2022 · 2 comments
Closed

Downtime each nexus configuration change #579

holmesb opened this issue Dec 23, 2022 · 2 comments
Labels

Comments

@holmesb
Copy link

holmesb commented Dec 23, 2022

Hi,

Great that nexus chart offers declarative configuration, but currently the configure.sh script only runs at startup, which means the pod gets restarted each change. Would be better to use a sidecar container. This will watch for changes to the configmap and run the script on-the-fly without downtime. I can create PR if\when I get the chance.

Cheers.

@stevehipwell
Copy link
Owner

@holmesb thanks for thinking about this. A sidecar is one option I've considered but I think my preferred option is to move the config out into a job. It should be possible to remove the shared filesystem requirement by starting with a known default password and working from there. I'd be happy to accept a PR, I was waiting for cleanups to be supported in the API which doesn't seem to have progressed at all.

@stale
Copy link

stale bot commented Jan 21, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 21, 2023
@stale stale bot closed this as completed Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants