-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Email Validations #67
Comments
@eclectic-coding thank you for taking the time to point this out. Email validation is tricky! I think the regex that Devise uses also fails in that case too. You'll note that the comment reads:
However, I think we can do a better job of accounting for this by using the correct input type on any form that deals with an email address. How would you feel about closing out this issue in favor of a new issue focused on using the correct input type? |
Sounds like a good approach. |
Closed in favor of #73 |
Steve,
I have been experimenting with
URI::MailTo::EMAIL_REGEXP
and it does not appear to be very robust.Examples
If you create a user with the email
user
it fails validations as it should.If you create a user with the email
user@example
it passes validations even though it is not a full email address.Might want to consider a more robust solution.
Thanks for the great resource.
Chuck
The text was updated successfully, but these errors were encountered: