Create PSyIR kernel arguments from new metadata classes (closes #2078) #2079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As mentioned above this PR depends on PR #2048 being on master before it can proceed. |
This was referenced Sep 27, 2023
Open
|
There's quite a long way to go to get the tests to pass flake8 - they're very much a WIP with variables assigned to but never used. |
|
Following what Rupert wrote in the description of this PR, I've modified gen_kernel_stub so that it uses the new functionality in this PR rather than the old, fparser1-based version. This should help me understand what this PR is doing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a subclass of the new
metadata_to_argument_rules.pybase class being implemented in PR #2048. This new subclass will create LFRic PSyIR kernel arguments. This is similar to the existing partial implementation inkernel_interface.pybut uses the new metadata and will be complete, so will replace this code. It will also replace the existingkern_stub_arg_list.pywhich uses the old style string arguments and the old style metadata and is used when generating kernel stub code. Once complete this new class can then be used to generate kernel stub code by replacing the existing implementation ingen_kernel_stub.py.