Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider generating an error on include loops #30

Open
realityforge opened this issue Mar 11, 2020 · 0 comments
Open

Consider generating an error on include loops #30

realityforge opened this issue Mar 11, 2020 · 0 comments
Labels
enhancement New feature or request
Milestone
Beta-2

Comments

@realityforge
Copy link
Collaborator

It is currently possible for fragment A to include fragment B which includes fragment A. This causes no problems as de-duplication occurs and the second include is ignored. The question is should it be a problem conceptually? Where should we detect this problem? It seems like it can only be detected safely when are processing an injector, in which case does it add additional complexity/cost and if so is it worth it?

If we decide this will not be done then we should also mark #29 as willnotfix
@realityforge realityforge added the enhancement New feature or request label Mar 11, 2020
@realityforge realityforge added this to the Beta-2 milestone Mar 11, 2020
@realityforge realityforge self-assigned this Apr 17, 2020
@realityforge realityforge removed their assignment Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
Beta-2
Development

No branches or pull requests
1 participant
@realityforge