Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR #825 breaks view-pdf for non-root hosting #943

Closed
mdecker opened this issue Mar 21, 2024 · 1 comment
Closed

PR #825 breaks view-pdf for non-root hosting #943

mdecker opened this issue Mar 21, 2024 · 1 comment
Labels
Bug Something isn't working

Comments

@mdecker
Copy link

mdecker commented Mar 21, 2024 •
edited
Loading

PR #825 (unintentionally?) changed the path of viewer.css to an absolute path. This breaks the view-pdf functionality for setups that don't host in root.
The problematic change is in the view-pdf.html template, line 38 (898ddae#diff-27c9b90465cae0be7c6a77866fce4391d846359471aee8dc0f67d7115fc3e5bfR38, https://github.com/Stirling-Tools/Stirling-PDF/blob/main/src/main/resources/templates/view-pdf.html#L38)
@sbplat sbplat added the Bug Something isn't working label Mar 21, 2024
@Frooodle
Copy link
Member

Fixed, release coming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mdecker @sbplat @Frooodle