Skip to content
This repository has been archived by the owner on Mar 14, 2019. It is now read-only.

Redesign monitoring internals #30

Merged
merged 4 commits into from
Jan 31, 2016
Merged

Commits on Jan 28, 2016

  1. Configuration menu
    Copy the full SHA
    aa8958e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8900b41 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2016

  1. redesign of the monitoring code

    Treating the rake task as the public interface here, but this would
    break anyone using the stuff in lib/monitoring
    
    * Created a real data type for the results of checks
    * Removed the "per queue" notifier, which was tightly coupled to its
      checker.  Now librato notifier can handle all of them
    * This should make it easier to add more advanced checks/notifications.
    
    To get confidence this won't break anything, I basically made the
    internal changes and kept running the monitoring integration test.  Once
    I'd made all the changes without that breaking, I then updated the unit
    tests.
    
    (The change in the monitoring integration test was just to add failure
    messages to the asserts. No actual changes were made)
    davetron5000 committed Jan 29, 2016
    Configuration menu
    Copy the full SHA
    79bc9b3 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2016

  1. typos and cleanups

    davetron5000 committed Jan 31, 2016
    Configuration menu
    Copy the full SHA
    b853ea9 View commit details
    Browse the repository at this point in the history