JSONObject#similar() fails to consider similar a number with/without trailing zero

[cdanger]

Hello,
as confirmed by #134 , numbers 1 and 1.0 should be considered the same in JSON. However, the method JSONObject#similar(Object) does not. Here is a simple test:

final JSONObject jsonWithTrailing0 = new JSONObject("{\"name\": 1.0}");
System.out.println(jsonWithTrailing0.toString()); // {"name":1}
final JSONObject jsonWithoutTrailing0 = new JSONObject("{\"name\": 1}");
Assert.assertTrue("Not the same!", jsonWithTrailing0.similar(jsonWithoutTrailing0)); // AssertionError: Not the same!

[stleary]

@cdanger Thanks for bringing up this issue. Changing existing behavior is generally not encouraged in this project, but let's see if others have an opinion.

[johnjaylward]

@cdanger can you run against the latest master? I believe this was fixed recently

[johnjaylward]

See #575

[cdanger]

Indeed, I had tried with the last release 20201115. And now with the latest master, I confirm it is fixed 👍 .
Looking forward to the next release! Anytime soon I hope :-) Thanks for your help.

[stleary]

A release will be scheduled before the end of this week.

[stleary]

Closed due to issue resolved in release 20210307