Made parameter model of QAbstractItemView.setModel optional #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When passing None to setModel the model will be removed from the view. Qt handles this internal by setting a dummy model when a null pointer is passed: https://stackoverflow.com/questions/46630185/qt-remove-model-from-view
|
Thanks for the PR. There is one more thing. Could you please add an entry to the Changelog. Cheers. |
|
Hey, I fixed the CI errors my PR produced by also correcting the subclasses. Updated the changelog on your request. :) |
stlehmann
approved these changes
Jul 4, 2020
|
Great work, thanks 👍 |
bluebird75
pushed a commit
to bluebird75/PyQt5-stubs
that referenced
this pull request
Aug 24, 2021
Made parameter model of QAbstractItemView.setModel optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing None to setModel the model will be removed from the view. Qt handles this internal by setting a dummy model when a null pointer is passed:
https://stackoverflow.com/questions/46630185/qt-remove-model-from-view