Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring settings.py #74

Closed
stlim0730 opened this issue Aug 2, 2016 · 1 comment
Closed

Refactoring settings.py #74

stlim0730 opened this issue Aug 2, 2016 · 1 comment

Comments

@stlim0730
Copy link
Owner

stlim0730 commented Aug 2, 2016

As the most important file in this Django project, settings.py must be in better shape in four senses.

  1. Scrub sensitive information from the file. Only the template is shared on the remote repository. Each contributor fill out the template on the local workspace.
  2. Allow flexible settings on database, web server, etc. It's currently hard-coded for Heroku-specific settings.
  3. Remove duplicate declarations and assignments. It has plenty of them now.
  4. Include missing details such as admin information. It's not crucial to run the application, but it should have as much information as possible.

This issue is also a starting point of #37. I'm assigning myself.

@stlim0730
Copy link
Owner Author

I came to conclude that this project requires rather app-level refactoring. Closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant