Fix bug in neorv32_slink_available() function #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unike267
force-pushed
the
fix_function
branch
from
257e599
to
6f9a8df
Compare
|
Hey @Unike267! Looks like a classical copy-and-paste error... 🙈 |
stnolting
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug in neorv32_slink.c library
In specific in neorv32_slink_available() function.
Context:
I added a module to NEORV32 via Stream Link interface (AXI4-Stream) and I used in .c program neorv32_slink_available() function to check if SLINK module was available. The point is that I put the IO_SLINK_EN => true in the top of the design and when I checked the results via UART the program crashed because neorv32_slink_available() return -1 when the SLINK module was available.
I checked the neorv32_slink.c and I found this bug.
When I remade the application_image compiled with the fixed-up library in local everything was good. I got the following results with CuteCom terminal:
/cc @umarcor