(pouchdb#7830) - Don't require an opaque string in the rev

* Don't require an opaque string in the rev This now matches the same regular expression in packages/node_modules/pouchdb-core/src/adapter.js, line 584 * Add a test that this patch fixes
sto3psl · Mar 10, 2021 · 9992954 · 9992954
1 parent 1fcac5d
commit 9992954
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/packages/node_modules/pouchdb-adapter-utils/src/parseDoc.js b/packages/node_modules/pouchdb-adapter-utils/src/parseDoc.js
@@ -46,7 +46,7 @@ var dataWords = toObject([
 ]);
 
 function parseRevisionInfo(rev) {
-  if (!/^\d+-./.test(rev)) {
+  if (!/^\d+-/.test(rev)) {
     return createError(INVALID_REV);
   }
   var idx = rev.indexOf('-');

diff --git a/tests/integration/test.bulk_docs.js b/tests/integration/test.bulk_docs.js
@@ -162,6 +162,21 @@ adapters.forEach(function (adapter) {
       });
     });
 
+    it("7829 bare rev 1- with new_edits=false", function (done) {
+      var db = new PouchDB(dbs.name);
+      var docs = [
+        {
+          _id: "foo",
+          _rev: "1-",
+          integer: 1
+        }
+      ];
+      db.bulkDocs({ docs: docs }, { new_edits: false }, function (err) {
+        should.not.exist(err, 'no error');
+        done();
+      });
+    });
+
     it('Test empty bulkDocs', function () {
       var db = new PouchDB(dbs.name);
       return db.bulkDocs([]);