Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(datastore): Refactor test names/comment and add OCC fake #85

Closed
wants to merge 3 commits into from

Conversation

stocaaro
Copy link
Owner

@stocaaro stocaaro commented Dec 19, 2023

Description of changes

Warning

PR reconstructed against main - Please see aws-amplify#12740

Outcome:

  • Test names changed to align with the harness features used per test
  • Add clear harness feature comments for each first use of a feature
  • Add the core logic for simulating OptimisticConcurrency service calls to the service Fake
  • Move harness.outboxSettled calls into harness behavior where they aren't adding inline clarity

The diff associated with this change is really hard to parse. If you hide whitespace it is much clearer what is happening.
image

Description of how you validated changes

Tests continue to pass with the same asserted outcomes.

Related changes

  1. refactor(datastore): Move conflict resolution tests to their own file aws-amplify/amplify-js#12728
  2. refactor(datastore): Refactor conflict resolution tests optimize for concise/readable aws-amplify/amplify-js#12732
  3. 🌱 test(datastore): Refactor test names/comment and add OCC fake
  4. refactor(datastore): Add OptimisticConcurrency tests #86
  5. fix(datastore): Update outbox comparison logic to fix update versioning problems #87

Checklist

  • PR description included
  • yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant