Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datastore): Update outbox comparison logic to fix update versioning problems #87

Closed
wants to merge 1 commit into from

Conversation

stocaaro
Copy link
Owner

@stocaaro stocaaro commented Dec 19, 2023

Description of changes

Outcome:

  • To allow multiple partial updates, outbox checks compare all updated fields for deep equality with the returned object, but ignore extra returned fields when gating outbox _version maintenance.
  • As a result, our rapid update use-cases will not drop updates

Issue #, if available

Description of how you validated changes

Validated by updating tests and testing against sample apps manaully for both Automerge and OCC usecases

Related changes

  1. refactor(datastore): Move conflict resolution tests to their own file aws-amplify/amplify-js#12728
  2. refactor(datastore): Refactor conflict resolution tests optimize for concise/readable aws-amplify/amplify-js#12732
  3. refactor(datastore): Refactor test names and make subscription events more sample app like aws-amplify/amplify-js#12740
  4. test(datastore): Add OptimisticConcurrency tests aws-amplify/amplify-js#12795
  5. 🌱 fix(datastore): Update outbox comparison logic to fix update versioning problems

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant