refactor(datastore): Add OptimisticConcurrency tests #86
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
PR reconstructed as part of a rebase - Please see #88
Description of changes
Outcomes:
errors
are present aligning mock behavior with the client logic it overrides.While adding OCC testing, I noticed my sample app result diverged from our test results. Investigating this led me to identify that this is substantially true for our existing Automerge tests. The difference comes from having subscription updates arrive into datastore before the mutation response is returned. This is possible, but not the common case. I have factored the latent tests towards the more common case which is has noisier redundant messages.
Description of how you validated changes
By comparing sample app results to test expectations and iterating until they align.
Related changes
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.