Skip to content
This repository has been archived by the owner on Jan 6, 2023. It is now read-only.

Package as compiled JS #38

Closed
kum-deepak opened this issue Nov 7, 2017 · 10 comments
Closed

Package as compiled JS #38

kum-deepak opened this issue Nov 7, 2017 · 10 comments

Comments

@kum-deepak
Copy link
Member

Currently this library is distributed as ts files. We need to package it as compiled JS.

@Sabartius
Copy link

This package is really helpful, we use it for several internal libraries: https://github.com/dherges/ng-packagr

@kum-deepak
Copy link
Member Author

I have done some work using https://github.com/dherges/ng-packagr , please follow branch bin. The binary package has not been tested fully yet. Please point to https://github.com/stomp-js/ng2-stompjs/releases/download/0.5.0-bin/stomp-ng2-stompjs-v0.5.0.tgz as your installation source.

The bundled version should be compatible for Angular 2, 4, and 5.

Once I have some success reports, I will make this part of the general release.

@Sabartius
Copy link

Sabartius commented Nov 16, 2017

@kum-deepak I tried your package, it works with Angular 5 & AngularCLI 1.5 :)

@weichcri
Copy link

@kum-deepak your package worked fine, thanks ;)

@domkrel
Copy link

domkrel commented Nov 20, 2017

It works for me. ng-packagr did the job! @kum-deepak

@kum-deepak
Copy link
Member Author

Great to hear! I will switch to this packaging soon, may be this weekend.

@pedroapy
Copy link

I read you are using ng-package, but just if this may be something useful for you, in this PR: #39 I'm doing the code to generate a dist folder with necessary javascript code for distributing your library using gulp as the angular-material team does. Moreover, I'm removing all unnecessary dependencies like angular-cli.

@domkrel
Copy link

domkrel commented Nov 21, 2017

@kum-deepak I hope you will release it soon. In our company setup we can only use officially released npm packages.

@kum-deepak
Copy link
Member Author

kum-deepak commented Nov 21, 2017

Released as 0.6.1, please try.

@kum-deepak
Copy link
Member Author

If no further issue reported, I will close this issue in few days.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants