Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider IFrame, IMessage, ITransaction interfaces #25

Closed
kum-deepak opened this issue Nov 7, 2018 · 2 comments
Closed

Consider IFrame, IMessage, ITransaction interfaces #25

kum-deepak opened this issue Nov 7, 2018 · 2 comments
Labels
enhancement New feature or request
Milestone
5.1.0

Comments

@kum-deepak
Copy link
Member

Sometimes we can get tricky errors because of private members not matching. Suggested way to avoid is to create Interfaces corresponding to those classes.

In particular Message and Transactions are not created by calling constructors. Objects are created first and claimed to be a Message/Transaction.
@kum-deepak kum-deepak added the enhancement New feature or request label Nov 25, 2018
@kum-deepak kum-deepak added this to the 5.1.0 milestone Dec 2, 2018
@kum-deepak
Copy link
Member Author

Code is complete, need to test other libraries to ensure type library symbols are backwards compatible.

@kum-deepak
Copy link
Member Author

Tested with master branches of rx-stomp and ng2-stompjs. These are now added to be tested after every commit at Travis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
5.1.0
Development

No branches or pull requests
1 participant
@kum-deepak