Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wishlist: convert specs to RSpec3 style #114

Closed
boutil opened this issue Aug 13, 2015 · 4 comments
Closed

wishlist: convert specs to RSpec3 style #114

boutil opened this issue Aug 13, 2015 · 4 comments

Comments

@boutil
Copy link

boutil commented Aug 13, 2015

Hi,

Would you please consider modify the syntax of the specs to make them run with RSpec3?
Basically, it boils down:
-replace be_true and be_false by be true and be false
-replace stub! by stub, and mock by double

The following spec 'should return an empty message when receiving an empty string or nil parameter' in message_spec.rb fails with RSpec3 because empty? is a private method.

@gmallard
Copy link

@boutil - Hello. Hope you still have this on your radar.

I agree, the differing Rspec levels need to be addressed .... somehow.

See #117 for a related conversation.

@gmallard
Copy link

Can you please try the gem code:

  1. In my personal clone: https://github.com/gmallard/stomp
  2. HEAD of branch 'rsvertst'

and let me know if it meets your requirements for RSpec 3.

Please provide detailed feedback if this 'fails'.

Thanks, G.

@gmallard
Copy link

gmallard commented Mar 3, 2016

Please try gem version 1.3.5.

Let me know if there are problems.

Please close this issue of all is OK.

Regards, Guy

@gmallard
Copy link

gmallard commented Mar 7, 2016

Fix: b3576a3

Version: 1.3.5

Please install the latest gem.

@gmallard gmallard closed this as completed Mar 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants