Skip to content
This repository has been archived by the owner on May 30, 2022. It is now read-only.

Reflected shots cause walls to be threatening #295

Closed
amylizzle opened this issue May 14, 2022 · 2 comments · Fixed by #298
Closed

Reflected shots cause walls to be threatening #295

amylizzle opened this issue May 14, 2022 · 2 comments · Fixed by #298
Labels
bug Something isn't working

Comments

@amylizzle
Copy link
Contributor

Labels

[BUG]

Description

Walls are marked by the protection component

Steps to reproduce

  1. Convert walls in a room
  2. Have a drone shoot something and miss
  3. Shot bounces off of the flock walls
  4. Hits another flock thing

image

Expected Behavior

Reflected shots probably shouldn't count for threats? or something

Additional Information & Screenshots

No response

@keywordlabeler keywordlabeler bot added the bug Something isn't working label May 14, 2022
@FlameArrow57
Copy link
Contributor

I think ideally reflected projectiles should be retaining their original shooter? Ex. someone shoots a projectile, and flockdrones report the person as having attacked every wall hit.

It just happens that Flock walls can reflect projectiles, don't know about any other wall reflecting, but ex. use case otherwise would be for logs, which do keep track of shooter I believe, in which case they would be wrong here.

@amylizzle
Copy link
Contributor Author

amylizzle commented May 15, 2022

@stonepillars suggested just throwing an ismob() check on the protection component. I would add iscritter() to that also, just in case. Oh and isvehicle()

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants