Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecl in Noetic #104

Closed
fmrico opened this issue May 24, 2020 · 12 comments
Closed

ecl in Noetic #104

fmrico opened this issue May 24, 2020 · 12 comments
Assignees
Milestone

Comments

@fmrico
Copy link

fmrico commented May 24, 2020

Dear @stonier

There will be a release for Noetic? I am using kobuki, and it depends on ecl :)

Thanks!!

@stonier
Copy link
Owner

stonier commented Jun 3, 2020

On their way

@m2kulkarni
Copy link

How can i build such that it is comaptible with noetic?

@stonier
Copy link
Owner

stonier commented Jun 6, 2020

I haven't tried it myself but you should be able to just drop ecl_tools, ecl_lite, sophus and ecl_core into your workspace like any other ros repository.

@stonier
Copy link
Owner

stonier commented Jun 6, 2020

Tracking RosDistro PR's

@m2kulkarni
Copy link

Hey, so i tried doing that. I cloned this repository into my workspace and then did catkin_make but there is a error Error: Packages with unknown build types exist Can not build workspace with packages of unknown build_type.
Screenshot from 2020-06-06 21-56-03

@stonier
Copy link
Owner

stonier commented Jun 6, 2020

I suspect you've got the wrong branches. The default branch for ecl repositories now targets ROS2.

This ecl.repos should work for noetic, or at least give you the hint. I don't have noetic installed yet, so let me know how it goes.

@m2kulkarni
Copy link

Hey, so basically I am trying to run Champ . In that it automatically clones yocs_velocity_simulator. I saw your comment on yocs too.
Screenshot from 2020-06-07 22-25-19

Also as you suggested, i tried cloning the melodic release version but the errors persisted

@stonier
Copy link
Owner

stonier commented Jun 7, 2020

That's a fairly generic message that usually indicates it's not around or has been skipped because catkin doesn't know what to do with it. You'll have to dig around earlier in the build output to grokk that. Unfortunately, I don't have a 20.04 installation yet, so can't try to reproduce here.

If there is something peculiar to 20.04, I'll get some signal from the build farm once those PR's get into rosdistro.

@stonier
Copy link
Owner

stonier commented Jun 8, 2020

Looks like I need a noetic install after all - there are some critical warnings turning into errors being caught on 20.04 that weren't being caught on 18.04 :)

@m2kulkarni
Copy link

Hey, sorry for not replying. It actually did build successfully. I guess sopheus wasnt working with other packages so i built it in another workspace and ecl_toos, ecl_core and ecl_lite in another. Thankully now there are no errors when i try to catkin_make champ. BUT the models are still not working, but i guess that has nothing to do with ecl.(i have posted that as another issue

Thanks for the replies, it helped me figure out things. You may go ahead and close the issue. Thanks again

@stonier
Copy link
Owner

stonier commented Jun 8, 2020

Ah, the release version in CI is setting stricter build flags I expect. And yes, I forgot with catkin you need sophus (pure cmake project) in an underlying workspace. Good to hear it works.

Keeping this open - still tracking the noetic release.

@stonier
Copy link
Owner

stonier commented Aug 28, 2020

Debs are in.

@stonier stonier closed this as completed Aug 28, 2020
@stonier stonier self-assigned this Aug 28, 2020
@stonier stonier modified the milestones: Eloquent, Noetic Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants