-
-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚀 Feature: localization #84
Comments
I can work on this, implementing i18n localization shouldn't be too difficult. I can't translate everything obviously, but I can start getting the framework laid out so translations can be implemented |
Just a little heads up, the way the localization is going to work is there will be json files for each language which includes the translated strings. Each page will reference the strings in the json file instead of typing the strings manually. The default locale can be specified manually in the config, through automatic browser detection, or maybe stored on a per-user basis (to remember their preferred locale, configured in settings?) |
@stautonico That would be awesome! It would really appreciate if you could implement the localization feature. Translating should be easy, because users could then contribute to translations without having coding knowledge. I think it would be nice if it detects the browser locale but the user should then be able to manually change the language in the settings. Keep in mind that the error messages on the backend should be translated too, is this difficult to implement? |
Backend translation would have to be configured manually through an environment variable or config somewhere. It would also require separate work, but it shouldn't be that hard. |
I'm not a programmer but I can help translate into Portuguese (Brazil). The Pingvin Share is awsome! |
@lfac76 Thank you! We let you know when the implementation is ready :) |
@stonith404 I hope this will be resolved soon, but apparently prisma (^4.9.0) no longer works on arch. The issue was opened on the prisma repo yesterday. This prevents me from working on the latest version of prisma. I'm going to downgrade prisma on my local build so I can work on it.I hope this won't cause any issues. |
I'm not a programmer, hopefully one day :-) |
@stautonico Not sure if it matters, but apparently the dev of prisma said it was a mere warning, not an actual error message. If prisma worked before on your platform (arch), it will continue to do so. They just added the warning message in 4.9.0. As per: prisma/prisma#17545 (comment) And supposedly |
@stautonico are you still interested on working on this issue? |
I would like to, but I've been very busy with school. If there's anyone who would want to take over, I'd be okay with that, otherwise, I would like to pick back up on it once school slows down. |
@stautonico Yeah sure, take your time :) |
I can translate to Thai |
Hey there! I could help with Spanish translation. |
I'd happy to help translating into Chinese Simplified |
Hey! Can I start working on this? I think I know how to do it 😸 |
@Rooyca Thanks for your interest but @stautonico is almost finished with the implementation: https://github.com/stautonico/pingvin-share/tree/feat-84-localization There are some minor issues that we have to solve but I think it will be ready in maximum 2 weeks, as I have holidays coming up soon |
Awesome! Are you guys using i18next? If that's the case, I could start translating into Spanish... I'd need the json to reference |
@Rooyca We use |
After giving the start signal for the translation work, I could translate the texts to German. |
Sure, it'll be ready for translations soon! |
Hey ! Any news ? I could help with French translation. |
@stautonico has worked on this feature and came really far. Currently I'm studying for my final exams and I don't have the time to work on the project but as soon as I'm finished, I'll finish this feature if @stautonico doesn't want to :) |
Yes, I'm almost done with my semester. I have one final left on Friday, and then I have the rest of the summer to work on it :) |
What could be nice is to use a platform such as Crowdin, Weblate, that could ease the work of translators (instead of editing json files) Ready to help translating in French as well. |
@EttSimon Good idea, this would allow users who are not experienced in coding and Git to contribute to the translations. |
Hey! I just joined the Crowdin project 😸 |
Come to think, if things don't work out with Crowdin, changing to another tool should not be so complicated as most of the work seems to be on the code itself. :) Welcome @Rooyca |
yes, it's just a file like this right? I could start translating today jajaj :) |
@stonith404 Can you add Danish, to Crowdin? Then i will translate it :-) |
Are we already starting translating? the linked PR is still draft 🧐 |
Idk, i just found https://crowdin.com/project/pingvin-share |
Let @stonith404 give us the start, I don't think he is ready yet. Plus if we translate too soon and he have to start the Crowdin over, we risk loosing our work. Let's wait for the official signal, shall we? |
Sounds like a great plan🚀 |
Yeah I'm almost finished. Currently the admin configuration page and the input validations needs some work but then I'm done. |
Everything should be ready now. I only have to add a language picker. I'm playing around with Crowdin but I'm a bit confused. Is there anyone that has some experience as an administrator with Crowdin? |
Not an admin but ask anyway maybe I could help ? |
@EttSimon Ah nice. It confuses me that everyone can just translate the strings without any verification or approval. I've created a test account for translating on Crowdin and after I translated some strings crowdin automatically pushed these changes to the translation branch. Trollers could translate some bad stuff and this would get pushed directly. Is there a way to prevent this? |
There is definitively a toggle or community management mode somewhere because at gitea, translators need to be granted approvers to approve (lol) translations (regardless of the best voted, if it come from a user or a bot) ; otherwise the translation is not included at release. |
@EttSimon Okay thanks, I'll look into it. I'll also take a look into the docs, I hope they're useful. |
The branch is merged 🎉I'll wait for a few translations before I release it. I would love if you could help to translate Pingvin Share :) German : @Hoerch How you can help with translating
Feel free to participate in the localization discussion :) |
Btw a big thank you to @stautonico for developing the biggest part in this feature. |
Wow, there's a lot of translations going on already. |
Great job!
I'm moving and couldn't start the translation, sorry!
I hope to be able to start the translation in a couple of weeks.
Em sáb., 22 de jul. de 2023 às 19:14, Elias Schneider <
***@***.***> escreveu:
… [image: Screenshot 2023-07-23 at 00 12 ***@***.***
<https://user-images.githubusercontent.com/58886915/255352856-9c78970d-2c00-43c5-9aff-73330a43910a.png>
Thanks everyone for helping to translate Pingvin Share! I'll release the
new version tomorrow :)
—
Reply to this email directly, view it on GitHub
<#84 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AT45SGBPS4O32LZHI6DIB6TXRRGCRANCNFSM6AAAAAAUDGV56E>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Released :) |
thank you @stonith404 for allowing it :) |
Hi,
I translated to pt-BR but the site says pt-PT. Is it possible to change
this to pt-BR and create another one pt-PT? pt-BR is portuguese from Brazil
and pt-PT from Portugal.
Thanks a lot.
Em dom., 23 de jul. de 2023 às 11:56, Simon Priet ***@***.***>
escreveu:
… thank you @stonith404 <https://github.com/stonith404> for allowing it :)
—
Reply to this email directly, view it on GitHub
<#84 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AT45SGB355EU4WQMZIZLJYDXRU3SLANCNFSM6AAAAAAUDGV56E>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@lfac76 Oh sorry, yes sure I'll change that. How should I name Brazilian Portuguese in the language picker? Currently it is "Português". |
No problem... Yes, it could be Brazilian Portuguese.
Em seg., 24 de jul. de 2023 às 03:17, Elias Schneider <
***@***.***> escreveu:
… @lfac76 <https://github.com/lfac76> Oh sorry, yes sure I'll change that.
How should I name Brazilian Portuguese in the language picker? Currently it
is "Português".
—
Reply to this email directly, view it on GitHub
<#84 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AT45SGG5YRXTLEPB4GBJEW3XRYHORANCNFSM6AAAAAAUDGV56E>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@lfac76 Okay, so |
@lfac76 are Portuguese and Brazilian Portuguese really diffent at the scale of the application ? |
@lfac76 <https://github.com/lfac76> Okay, so Português do Brasil would be
correct?
Yes, it's correct! Thanks.
@lfac76 <https://github.com/lfac76> are Portuguese and Brazilian Portuguese
really diffent at the scale of the application ?
Yes, they are diferents. We can understand each other, but they are a lots
of words very diferents. It's really strange read the "other" portuguese.
Best Regards.
Em seg., 24 de jul. de 2023 às 11:15, Pierre Bidet ***@***.***>
escreveu:
… @lfac76 <https://github.com/lfac76> are Portuguese and Brazilian
Portuguese really diffent at the scale of the application ?
—
Reply to this email directly, view it on GitHub
<#84 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AT45SGEQPF7H7L73HI77DRLXRZ7QXANCNFSM6AAAAAAUDGV56E>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
🔖 Feature description
We should implement localization for the Pingvin Share website. The functionality for localization isn't implemented yet and I've never done this before, but I try to implement this ASAP.
If someone wants to help to translate or help with the technical stuff for localization, feel free leave a comment :)
🎤 Pitch
By implementing localization on the website, we can enhance the user experience for non-English speakers and make it more accessible and understandable for them.
The text was updated successfully, but these errors were encountered: