UX: Fix tab usage #280
UX: Fix tab usage #280
Conversation
There was a problem hiding this comment.
I'll review the code and try to debug — blocking this at the moment because it's completely broken in Safari.
Bug 1
The Tab does not work in Safari, it stays stuck on the header
If I push the tab button, the selection stays on account-id and it won't move
Bug 2
If I click the "Key" to add a new header, it won't work. The selection stays on account-id and it won't move from there. The only way to make it work is to delete all the headers
Bug 3
The tab seems to be working if I cancel all the headers, but it only goes through if I select a know header; if I write a custom one and I Tab, the selection won't move from there
|
@marcelltoth Updated with broken cases. It seems to be working fine in Chrome, so I guess this might be a problem for you to debug, isn't it? |
|
Apparently by removing the |
Well, it's going to be quite problematic for me to debug. There has been no Safari release for anything but macOS for a while, and I don't have such a thing. Neither of these is reproducible in Chrome, right? @ssspear maybe do you happen to have a MacBook? |
I do have a MacBook and can take a look. Crazy that there isn't a Safari download for Windows |
|
Yikes my Safari is straight up crashing every time I load this. Before it crashes, I do experience the same issue though. @XVincentX Should I work on debugging this since @marcelltoth won't be able to? |
|
@ssspear @marcelltoth No, this is low priority. Skip this. |
|
Closing because RM will be going through a remake. |
Closes #277
Closes #278
Having selected a suggestion with the arrow keys
And pressing the
TABkey leads to this state:The same thing happens when clicking on a suggested item instead of pressing
TAB.Typing a custom (unknown) header and pressing
TABleads to the same result: