Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add server variable support #76

Merged
merged 3 commits into from
Feb 27, 2020
Merged

Conversation

ssspear
Copy link
Contributor

@ssspear ssspear commented Feb 26, 2020

Related Issue: #53

  • Include servers and server variables when transforming an OpenAPI v3 spec to an IHttpService

@ssspear ssspear self-assigned this Feb 26, 2020
@ssspear ssspear marked this pull request as ready for review February 26, 2020 22:52
src/oas3/transformers/servers.ts Outdated Show resolved Hide resolved
src/oas3/transformers/servers.ts Outdated Show resolved Hide resolved
src/oas3/service.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@XVincentX XVincentX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropped some comments. It's almost good to go, but we can improve a little bit the way we're testing this.

If you need any clarifications just ping me!

src/oas3/__tests__/operation.test.ts Outdated Show resolved Hide resolved
src/oas3/__tests__/operation.test.ts Outdated Show resolved Hide resolved
src/oas3/__tests__/operation.test.ts Outdated Show resolved Hide resolved
src/oas3/__tests__/operation.test.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@XVincentX XVincentX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@XVincentX XVincentX merged commit 7017b05 into master Feb 27, 2020
@XVincentX XVincentX deleted the feat/server-variable-support branch February 27, 2020 20:23
@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version 2.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants