Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make top level rows non-collapsible #133

Closed
marcelltoth opened this issue Apr 9, 2021 · 1 comment
Closed

Make top level rows non-collapsible #133

marcelltoth opened this issue Apr 9, 2021 · 1 comment

Comments

@marcelltoth
Copy link
Contributor

Summary

This looks weird:
image

We understand the incentive behind not allocating another level of nesting (left-padding) for the top level rows. The conclusion was to further align JSV with the product designs, and make top level rows non-collapsible.

This way we could have the label of the top-level rows start at exactly at the top left of the component, adding the notion of nesting visually, yet keeping the position of the children unchanged.

@marcelltoth
Copy link
Contributor Author

Closing in favor of stoplightio/elements#1030

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant