Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught error causes endless spinner #49

Closed
lottamus opened this issue Sep 5, 2019 · 1 comment · Fixed by #51
Closed

Uncaught error causes endless spinner #49

lottamus opened this issue Sep 5, 2019 · 1 comment · Fixed by #51
Assignees
Labels
released t/bug Something isn't working

Comments

@lottamus
Copy link
Contributor

lottamus commented Sep 5, 2019

Describe the bug

As expected, adding an allOf with different types logs the following error to the console:

Uncaught Error: Could not resolve values for path:"type". They are probably incompatible. Values: "string" "number"

The UI displays an endless spinner with no information about the error.

To Reproduce

  1. Go to https://stoplightio.github.io/json-schema-viewer/?path=/story/jsonschemaviewer--custom-schema
  2. Add the following schema:
{
   "title": "All Of",
   "allOf": [
      {
         "type": "string"
      },
      {
         "type": "number"
      }
   ]
}

Expected behavior

An error boundary is shown displaying the error.

Screenshots

image

@lottamus lottamus added the t/bug Something isn't working label Sep 5, 2019
@P0lip P0lip self-assigned this Sep 5, 2019
@P0lip P0lip closed this as completed in #51 Sep 7, 2019
@stoplight-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 2.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released t/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants